/done

name: done
description: Complete a task with 6 Gates verification, code review, and career value extraction
allowed-tools: Read, Glob, Grep, Write, Edit, AskUserQuestion, Bash

/own:done

> ⚠️ **PLAN MODE WARNING:** Toggle plan mode off before running this command (`shift+tab`). OwnYourCode commands don't work correctly with plan mode.

Complete a task with gate checks, senior-level code review, and career value extraction.

Overview

This command is run when the user finishes a task or feature. It performs: 1. **Gate Checks** — 6 Mentorship Gates verification 2. **Code Review** — FAANG-level feedback on their code 3. **Task Completion** — Update the dashboard (task done, DoD, phase status) 4. **Interview Story** — Extract STAR format story (if career_focus allows) 5. **Resume Bullet** — Draft action-impact bullet (if career_focus allows)

**Profile-Aware Behavior:**

• Check `.claude/ownyourcode-manifest.json` for `profile.settings.career_focus`
• If `career_focus = "full-extraction"` → Run all phases including 5 and 6
• If `career_focus = "tips-only"` → Skip Phases 5 and 6
• If `career_focus = "none"` → Skip Phases 5 and 6, hide CAREER VALUE in summary

---

Execution Flow

Phase 1: Identify Completed Work

Question: "What did you just finish?"

Options:
1. A task from my active spec
   Description: Completing planned work

2. A bug fix
   Description: Fixed something that was broken

3. A feature (not specced)
   Description: Built something new

4. A refactor
   Description: Improved existing code

If from active spec, read the dashboard to understand context:

• Read `ownyourcode/dashboard/dashboard-data.js` (`window.PROJECT`)
• Find the active phase (first with `status !== "complete"`) and the relevant

task in its `tasks[]` (match by `text`/`detail`, note its `id`)

• Note what they were building and why (the phase `spec` / `design`)

---

Phase 2: Gather Changes

Review what code was written:

# Recent commits
git log --oneline -5

# Files changed
git diff --name-only HEAD~1

# Or if uncommitted
git status

Ask them to point to the key files:

> "Which files contain the main implementation?"

Read those files to understand what they built.

---

Phase 2.5: Gate Checks (THE 6 GATES)

Before code review, run through the 6 Mentorship Gates. These ensure quality and understanding.

> "Before we review the code, let's run through the 6 Gates."

Gate 1: Ownership (CAN BLOCK)

*Reference: `.claude/skills/gates/ownership/SKILL.md`*

> "Walk me through what this code does, step by step."

**Questions:** 1. "Why did you choose this approach? What alternatives did you consider?" 2. "If the requirements changed to [X], what would you modify?"

**Outcomes:**

• **PASS**: Junior demonstrates clear understanding
• **BLOCKED**: Junior cannot explain → "Let's pause. Review the code and come back when you can explain it."

Gate 2: Security (WARNINGS)

*Reference: `.claude/skills/gates/security/SKILL.md`*

> "Where does user input enter this feature?" > "How is that input validated?"

**Check for:**

• Input validation present
• Authorization checks
• No hardcoded secrets
• No SQL/XSS vulnerabilities

**Outcomes:**

• **PASS**: No issues found
• **WARNING**: Issues found → Note them for code review

Gate 3: Error Handling (WARNINGS)

*Reference: `.claude/skills/gates/error/SKILL.md`*

> "What happens if [main operation] fails?" > "What does the user see when an error occurs?"

**Check for:**

• No empty catch blocks
• User-friendly error messages
• Loading states cleared on error
• Errors logged for debugging

**Outcomes:**

• **PASS**: Error handling appropriate
• **WARNING**: Issues found → Note them for code review

Gate 4: Performance (WARNINGS)

*Reference: `.claude/skills/gates/performance/SKILL.md`*

> "What happens when there are 10,000 items?" > "How many database queries does this make?"

**Check for:**

• No N+1 queries
• Pagination for lists
• No unnecessary re-renders
• Cleanup of intervals/subscriptions

**Outcomes:**

• **PASS**: No obvious issues
• **WARNING**: Issues found → Note them for code review

Gate 5: Fundamentals (SUGGESTIONS)

*Reference: `.claude/skills/gates/fundamentals/SKILL.md`*

> "Would a new developer understand this code?"

**Check for:**

• Descriptive naming
• Reasonable function size
• No magic numbers
• Appropriate abstractions

**Outcomes:**

• **PASS**: Code quality is solid
• **SUGGESTIONS**: Polish items → Note for consideration

Gate 6: Testing (WARNINGS)

*Reference: `.claude/skills/gates/testing/SKILL.md`*

> "What tests prove this feature works?"

**Questions:** 1. "What tests did you write for this feature?" 2. "What edge cases do your tests cover?" 3. "If I broke [specific part], which test would catch it?"

**Check for:**

• At least one test exists
• Happy path is covered
• At least one edge case considered
• Tests actually run (not skipped)

**Outcomes:**

• **PASS**: Tests exist and cover critical paths
• **WARNING**: No tests or weak coverage → Encourage but don't block

**Note:** This gate issues WARNINGS only. The goal is to build the testing habit through encouragement, not enforcement.

Gate Summary

┌─────────────────────────────────────────┐
│           GATE CHECK RESULTS            │
├─────────────────────────────────────────┤
│ 1. Ownership:    ✅ PASS / 🛑 BLOCKED   │
│ 2. Security:     ✅ PASS / ⚠️ WARNING   │
│ 3. Error:        ✅ PASS / ⚠️ WARNING   │
│ 4. Performance:  ✅ PASS / ⚠️ WARNING   │
│ 5. Fundamentals: ✅ PASS / 💡 SUGGEST   │
│ 6. Testing:      ✅ PASS / ⚠️ WARNING   │
└─────────────────────────────────────────┘

**If BLOCKED on Gate 1:** Stop here. The junior must understand their code before proceeding.

**If WARNINGS exist:** Note them and incorporate into code review. The junior should address them.

**If only SUGGESTIONS:** Proceed to code review. These are polish, not blockers.

---

Phase 3: Code Review (FAANG Level)

Perform a thorough code rev