/review-chamber

name: review-chamber
description: Captures and retrieves PR-review findings in memory palaces. Use after PR review to store architectural decisions, patterns, and standards for future reference.
alwaysApply: false
usage_patterns:
- capture-review: After PR review completion, capture significant findings
- search-decisions: Find past architectural decisions
- pattern-lookup: Retrieve recurring issues and solutions
- standards-reference: Access quality standards from past reviews
dependencies:
- memory-palace:knowledge-intake
- sanctum:pr-review
model_hint: standard

Table of Contents

• [Overview](#overview)
• [Room Structure](#room-structure)
• [Workflow Phases](#workflow-phases)
• [Phase 1: Knowledge Detection](#phase-1:-knowledge-detection)
• [Knowledge Detection Checklist](#knowledge-detection-checklist)
• [Phase 2: Classification](#phase-2:-classification)
• [Phase 3: Capture](#phase-3:-capture)
• [Decision Title](#decision-title)
• [Decision](#decision)
• [Context (from PR discussion)](#context-(from-pr-discussion))
• [Captured Knowledge](#captured-knowledge)
• [Connected Concepts](#connected-concepts)
• [Phase 4: Integration](#phase-4:-integration)
• [Usage Examples](#usage-examples)
• [Capture After PR Review](#capture-after-pr-review)
• [Search Past Decisions](#search-past-decisions)
• [Surface Relevant Knowledge](#surface-relevant-knowledge)
• [Relevant Review Knowledge](#relevant-review-knowledge)
• [Integration Points](#integration-points)
• [With sanctum:pr-review](#with-sanctum:pr-review)
• [With knowledge-intake](#with-knowledge-intake)
• [With knowledge-locator](#with-knowledge-locator)
• [Evaluation Rubric](#evaluation-rubric)
• [Worth Capturing (Score ≥ 60)](#worth-capturing-(score-≥-60))
• [Skip (Score < 60)](#skip-(score-<-60))
• [CLI Reference](#cli-reference)
• [Best Practices](#best-practices)

PR Review Chamber Skill

Capture, organize, and retrieve knowledge from PR reviews within project memory palaces.

When To Use

• Capturing PR review knowledge for future reference
• Building review pattern libraries from past reviews

When NOT To Use

• Quick self-reviews of trivial changes
• Automated CI checks that cover the review scope

Overview

The Review Chamber is a dedicated room within each project palace that stores valuable knowledge extracted from PR reviews. It transforms ephemeral PR discussions into persistent, searchable institutional memory.

Room Structure

review-chamber/
├── decisions/      # Architectural choices from PR discussions
├── patterns/       # Recurring issues and their solutions
├── standards/      # Quality bar examples and coding conventions
└── lessons/        # Post-mortems and learnings

**Verification:** Run the command with `--help` flag to verify availability.

Workflow Phases

Phase 1: Knowledge Detection

After a PR review completes, evaluate findings for knowledge capture:

## Knowledge Detection Checklist

For each finding from sanctum:pr-review, evaluate:

- [ ] **Novelty**: Is this a new pattern or first occurrence?
- [ ] **Applicability**: Will this affect future PRs in this area?
- [ ] **Durability**: Is this architectural (capture) or tactical (skip)?
- [ ] **Connectivity**: Does it link to existing palace rooms?

**Verification:** Run the command with `--help` flag to verify availability.

Phase 2: Classification

Route findings to appropriate subrooms:

| Finding Type | Target Room | Criteria | |-------------|-------------|----------| | Architectural choice | `decisions/` | BLOCKING and architectural context | | Recurring issue | `patterns/` | Seen before or likely to recur | | Quality example | `standards/` | Exemplifies coding standards | | Learning/insight | `lessons/` | Retrospective or post-mortem |

Phase 3: Capture

Create structured entry with:

---
source_pr: "#42 - Add authentication"
date: 2025-01-15
participants: [author, reviewer1, reviewer2]
palace_location: review-chamber/decisions
related_rooms: [workshop/auth-patterns, library/security-adr]
tags: [authentication, jwt, security]
---

## Decision Title

### Decision
Chose JWT tokens over server-side sessions.

### Context (from PR discussion)
- Reviewer asked: "Why not use sessions?"
- Author explained: stateless scaling requirements
- Discussion refined: added refresh token rotation

### Captured Knowledge
- **Pattern**: JWT + refresh tokens for stateless auth
- **Tradeoff**: Complexity vs. horizontal scaling
- **Application**: Use for all API authentication

### Connected Concepts
- [[auth-patterns]] - Updated with JWT best practices
- [[security-adr-003]] - Referenced this decision

**Verification:** Run the command with `--help` flag to verify availability.

Phase 4: Integration

After capture, update related palace rooms:

1. Add bidirectional links to related entries 2. Update tags in project palace index 3. Notify if this contradicts existing entries

Usage Examples

Capture After PR Review

# Automatic: sanctum:pr-review triggers capture
/pr-review 42
# → Review posted to GitHub
# → Knowledge capture evaluates findings
# → Significant decisions stored in review-chamber

# Manual: Explicitly capture from PR
/review-room capture 42 --room decisions

**Verification:** Run the command with `--help` flag to verify availability.

Search Past Decisions

# Find authentication decisions
/review-room search "authentication" --room decisions

# Find patterns in a specific area
/review-room search "error handling" --room patterns --tags api

# List recent entries
/review-room list --limit 10 --room standards

**Verification:** Run the command with `--help` flag to verify availability.

Surface Relevant Knowledge

When starting work in a code area:

## Relevant Review Knowledge

Starting work in `auth/` directory...

**Past Decisions:**
- [#42] JWT token decision → decisions/jwt-over-sessions
- [#67] Rate limiting pattern → patterns/api-t