odoo-code-review

name: odoo-code-review
description: Review Odoo code for correctness, security, performance, and version-specific standards (Odoo 16, 17, 18, or 19). Use when reviewing Odoo modules, diffs, or pull requests; produce a scored report with weighted criteria.

Odoo Code Review

Objective

Review Odoo code changes against clear criteria, identify risks, and score using a weighted scale from an Odoo-expert perspective — using the reference pack that matches the target Odoo version.

Resolve the target Odoo version

Before reviewing, resolve `ODOO_VERSION` (one of `16.0`, `17.0`, `18.0`, `19.0`) in this order. Stop at the first one that succeeds:

1. **Explicit argument** passed to the agent invocation (e.g. `odoo_version: "19.0"`) or stated by the user. 2. **Project instructions**: the Odoo version stated in the project `CLAUDE.md` or `AGENTS.md`. 3. **The odoo-workflow helper**: the `version` line of `python3 <helper> env`, where `<helper>` is the `helper` the invocation passes (with its flags) or the newest `~/.claude/plugins/cache/unclecat-agent-skills/agent-skills/*/skills/odoo-workflow/scripts/odoo_trace.py`. It reads `.claude/odoo.json`, `.odoo-version`, `.claude/launch.json` and the conf the way step 4 describes. Exit 2 (`SETUP ERROR`, for example a version in `.claude/odoo.json` or `.odoo-version` that disagrees with `odoo/release.py`): stop and ask. 4. **Without the helper**: `grep -n "^version_info" <odoo_root>/odoo/release.py` (`(18, 0, ...)` → `18.0`) in the core located by `odoo_root` in `.claude/odoo.json`, the `odoo-bin` configuration in `.claude/launch.json` whose addons path covers the cwd, or the one `*.conf` whose uncommented `addons_path` covers the cwd, searched from the parent directory upwards (each level and its subdirectories; Odoo ignores `#` / `;` comment lines). An `odoo_version` in `.claude/odoo.json` or the first line of a `.odoo-version` file (cwd or nearest parent) must match it. 5. **Serie-prefixed manifest versions**: only `version` values (`'version'` or `"version"` keys) in workspace `__manifest__.py` files with four or five parts that start with the serie (`18.0.1.0`, `18.0.1.0.0`). Ignore short versions such as `'1.2'` or `'1.0.3'`; never count leading numbers. 6. **Nothing found**: write `version unknown` at the top of the review and stop to ask. Never default to a version.

If two sources disagree (e.g. the argument and `release.py`), stop and ask. Derive `ODOO_MAJOR` from `ODOO_VERSION` by stripping `.0` (e.g. `18.0` → `18`). All guide paths below use these placeholders.

Supported versions: **16.0, 17.0, 18.0, 19.0**. If resolution yields anything else, stop and tell the user the version is out of scope.

Locate the reference pack

`PACK_DIR` is the `odoo-<major>` pack directory (it holds `SKILL.md` and `references/`). Use `pack_dir` when the invocation passes it. Otherwise take the first directory that exists:

1. `~/.claude/plugins/cache/unclecat-agent-skills/agent-skills/<ver>/skills/odoo-${ODOO_VERSION}/` (Claude Code plugin; newest `<ver>`: `ls -d ~/.claude/plugins/cache/unclecat-agent-skills/agent-skills/*/skills/odoo-${ODOO_VERSION} | sort -V | tail -1`) 2. `~/.claude/skills/odoo-${ODOO_MAJOR}/` 3. `.claude/skills/odoo-${ODOO_MAJOR}/` 4. `~/.agents/skills/odoo-${ODOO_MAJOR}/` 5. `skills/odoo-${ODOO_VERSION}/` (a checkout of this repository)

None exists: write `pack not found` at the top of the review, skip every `${PACK_DIR}` read below, and review against the real source only. Never guess what the pack says.

Use `roots` (addons roots in `addons_path` order) when the invocation passes them to find the base code a change extends. With the helper (step 3), check what the diff relies on outside its own module: `python3 <helper> field MODEL FIELD[.FIELD...]`, `method MODEL METHOD --module MODULE` (a def the change relies on tagged `NOT in depends` is a missing dependency), `xmlid module.name`, and `unlisted MODULE` for files the manifest never loads. Exit 1 (NOT FOUND) or an unexplained unlisted file is a blocking issue; exit 2 means unknown, never missing.

Pre-review Requirements

• Read `${PACK_DIR}/SKILL.md` as the master index for the resolved version's guides.
• Read `${PACK_DIR}/references/api-highlights.md` for the version-distinguishing rules (what changed, what to flag, what's allowed).
• Read relevant guides from `${PACK_DIR}/references/` based on change scope:
• **Models/ORM**: `odoo-${ODOO_MAJOR}-model-guide.md`
• **Fields**: `odoo-${ODOO_MAJOR}-field-guide.md`
• **Decorators**: `odoo-${ODOO_MAJOR}-decorator-guide.md`
• **Performance**: `odoo-${ODOO_MAJOR}-performance-guide.md`
• **Views/XML**: `odoo-${ODOO_MAJOR}-view-guide.md`
• **Security**: `odoo-${ODOO_MAJOR}-security-guide.md`
• **Controllers**: `odoo-${ODOO_MAJOR}-controller-guide.md`
• **Transactions**: `odoo-${ODOO_MAJOR}-transaction-guide.md`
• **Mixins**: `odoo-${ODOO_MAJOR}-mixins-guide.md` (mail.thread, activities)
• **Testing**: `odoo-${ODOO_MAJOR}-testing-guide.md`
• **Migration**: `odoo-${ODOO_MAJOR}-migration-guide.md`
• **Actions**: `odoo-${ODOO_MAJOR}-actions-guide.md`
• **Data Files**: `odoo-${ODOO_MAJOR}-data-guide.md`
• **Manifest**: `odoo-${ODOO_MAJOR}-manifest-guide.md`
• Identify scope: module, file, and change context.
• Apply the version-distinguishing rules from `api-highlights.md` (e.g. `<tree>` vs `<list>`, `group_operator=` vs `aggregator=`, a missing `_name`: on 19 a class with neither `_name` nor a string `_inherit` becomes a model named after the class, with a warning).

Expert Review Process

1. **Scope**: Identify change scope, objectives, and key risks 2. **ORM & Model Methods**: Search patterns, CRUD operations, recordset operations 3. **Field Definitions**: Field types, computed fields, relational field parameters 4. **API Decorators**: `@api.depends`, `@api.constrains`, `@api.ondelete`, `@api.model_create_multi` 5. **Performance**: N+1 detection, batch operations, field selection 6. **Transact