/story-6.1.4

Story 6.1.4: Unified Greeting System Integration (v4 - Expanded)

**Story ID:** 6.1.4 **Epic:** Epic-6.1 - Agent Identity System **Wave:** Wave 1 (Foundation) **Status:** 📋 Ready to Start **Priority:** 🔴 Critical **Owner:** Dev (Dex) **Created:** 2025-01-14 **Updated:** 2025-01-17 (v4 - Unified System Integration) **Duration:** 2.5 days (20 hours) **Investment:** $250.00

---

📋 Objective

**EXPANDED SCOPE:** Implement a unified greeting system that integrates all greeting components (session context, project status, agent personalization, user preferences) into a single, optimized, and maintainable solution. This story unifies Stories 6.1.1 through 6.1.6 into a cohesive system that actually works.

**Original Scope (Already Implemented):**

• ✅ User-configurable greeting preferences (auto/minimal/named/archetypal)
• ✅ `GreetingPreferenceManager` class
• ✅ CLI commands for preference management
• ✅ Integration with `GreetingBuilder`

**New Scope (This Story):**

• 🔄 Expand `agent-config-loader.js` to load complete agent definitions
• 🔄 Create unified `generate-greeting.js` wrapper
• 🔄 Modify `greeting-builder.js` to accept pre-loaded context
• 🔄 Update all 11 agents to use unified system
• 🔄 Implement session state updates after commands
• 🔄 Consolidate duplicate scripts
• 🔄 Fix integration issues identified in technical review

---

🎯 Story

**As a** AIOX framework user, **I want** agents to use a unified greeting system that integrates session context, project status, agent personalization, and user preferences, **So that** I have a consistent, fast, and contextually relevant experience when activating any agent.

**Business Value:**

• Unifies all previous greeting-related work (Stories 6.1.1-6.1.6)
• Fixes integration issues preventing components from working together
• Provides optimal performance (<150ms with timeout protection)
• Maintains backward compatibility with fallbacks
• Simplifies architecture by consolidating duplicate scripts

---

🔗 Context: Integration of Previous Stories

Stories Already Implemented (But Not Integrated):

**Story 6.1.1:** Agent Persona Definitions ✅

• Agent definitions with `persona_profile.greeting_levels`
• **Status:** Implemented, but agents don't use it

**Story 6.1.2.4:** Project Status Context ✅

• `project-status-loader.js` with 60s cache
• **Status:** Implemented, but agents don't use it

**Story 6.1.2.5:** Contextual Agent Load Integration ✅

• `greeting-builder.js` with session detection
• `session-context-loader.js` for multi-agent continuity
• `context-detector.js` for session type detection
• `workflow-navigator.js` for workflow suggestions
• **Status:** Implemented, but agents don't use it

**Story 6.1.2.6:** Framework Configuration System ✅

• `agent-config-loader.js` for lazy loading
• **Status:** Implemented, but doesn't load agent definitions

**Story 6.1.4 (Original):** Greeting Preferences ✅

• `greeting-preference-manager.js`
• `greeting-config-cli.js`
• **Status:** Implemented, but agents don't use it

**Story 6.1.6:** Output Formatter ✅

• Output formatting utilities
• **Status:** Implemented

Current Problem:

**Agents use inline logic in STEP 3:**

- STEP 3: |
    Generate contextual greeting using inline logic:
    1. Detect session type: If first message → "new"
    2. Build greeting manually...
    3. Get project status (use Bash tool)...
    4. Show commands...

**Problems:**

• ❌ Claude Code doesn't have access to `conversationHistory`
• ❌ Session detection always returns "new"
• ❌ Commands always show "full" visibility
• ❌ Doesn't use any of the developed scripts
• ❌ Session state never updated after commands

Solution:

**Unified greeting generator called via Node.js:**

- STEP 3: |
    Generate greeting by executing unified greeting generator:
    1. Execute: node .aiox-core/scripts/generate-greeting.js {agent-id}
    2. Capture the complete output
    3. Display the greeting exactly as returned
    
    If execution fails:
    - Fallback to simple greeting: "{icon} {name} ready"
    - Show: "Type *help to see available commands"

---

📊 Technical Analysis Summary

Analysis Documents Integrated:

1. **QA Analysis** (`docs/qa/comprehensive-greeting-system-analysis.md`)

• Identified integration failure between components
• Proposed unified wrapper solution
• Performance targets: <50ms (cache), <150ms (no cache)

2. **Architect Consolidation Analysis** (`docs/architecture/scripts-consolidation-analysis.md`)

• Identified duplicate scripts (`config-loader.js` vs `agent-config-loader.js`)
• Recommended expanding `agent-config-loader.js` instead of creating new loader
• Identified 4 temporary migration scripts to delete

3. **Architect Technical Review** (`docs/architecture/technical-review-greeting-system-unification.md`)

• Identified 3 critical issues:

1. `AgentConfigLoader` doesn't return complete agent definition 2. Context structure inconsistency (duplicate loading) 3. Missing validation of agent structure

• Approved architecture with mandatory modifications

Critical Issues to Fix:

1. **🔴 CRITICAL:** Expand `agent-config-loader.js` to load complete agent definitions 2. **🔴 CRITICAL:** Modify `greeting-builder.js` to accept pre-loaded context 3. **🔴 CRITICAL:** Create `generate-greeting.js` using expanded loader 4. **🟡 MEDIUM:** Add validation and normalization of agent definitions 5. **🟡 MEDIUM:** Improve error handling and logging

---

📋 Tasks Breakdown

Phase 1: Script Consolidation (4.5 hours)

**Task 1.1: Expand `agent-config-loader.js` (2 hours)**

**Objective:** Add capability to load complete agent definition from markdown file

**Implementation:**

Add to `.aiox-core/scripts/agent-config-loader.js`:

/**
 * Agent definition cache (5 min TTL)
 */
const agentDefCache = new Map();

/**
 * Load complete agent definition from markdown file
 * 
 * @param {Object} optio