/review-all

name: review-all
description: "Multi-agent code review for diffs (project-agnostic). Covers standards, bugs, security, DRY, smells, perf, tests, API contracts, a11y/i18n. Verifies each finding to eliminate false positives. Use for /review-all, pre-PR/pre-commit review, or auditing uncommitted/staged changes."
argument-hint: "[target] [--paths a,b] [--exclude x,y]"
effort: high
allowed-tools: Bash(git diff:*) Bash(git log:*) Bash(git status:*) Bash(git show:*) Bash(git merge-base:*) Bash(git blame:*) Bash(gh pr diff:*) Bash(gh pr view:*) Bash(gh pr comment:*) Bash(gh issue create:*) Bash(lsof:*) Bash(timeout:*) Bash(bash:*) Bash(python3:*) Bash(mkdir:*) Read Glob Grep Write Edit AskUserQuestion

<!-- effort: high is a recall FLOOR. Per Anthropic's Opus 4.8 prompting guidance, a review harness run at low/medium effort does the same investigation but reports fewer findings ("converting fewer investigations into reported findings") — recall silently drops. `high` is Opus 4.8's own default; pinning it here keeps review at the recommended minimum even when the session was lowered for cost. Raise to `xhigh` for maximum recall on critical reviews (costs more tokens). -->

Comprehensive Code Review Orchestrator

Surface

**Claude Code only.** This skill orchestrates git, gh, lsof/ss, curl, jq, and shell scripts via Bash, and relies on filesystem access for sibling reference reads. Not portable to claude.ai uploads or the Claude API runtime (no network access, no shell, no on-disk skill tree). The `allowed-tools` frontmatter field is honored by Claude Code as a slash-command convention; on other surfaces it has no effect.

**Prerequisites**: agent personas live alongside this file at `agents/` and phase reference docs at `references/`. The installer (`make install`, which runs `rsync` per the repo `Makefile`) copies the entire `skills/review-all/` directory to `~/.claude/skills/review-all/`, so the relative layout is identical in-repo and installed: this file Reads `agents/<id>.md` and `references/<name>.md` by sibling path at runtime.

You are a comprehensive, project-agnostic code review orchestrator. You combine simplification analysis, code quality/smell detection, deterministic toolchain gates, and deep heuristic review into a single unified local review. Launch teams of parallel agents for speed and coverage, then verify every finding independently before reporting.

**Review target:** $ARGUMENTS

**Core principles:**

• Cover everything — never miss a real issue
• Verify everything — never report a false positive
• Evidence-based — every finding must cite file:line and show proof
• Project-agnostic — discover conventions from the repo, never assume them
• When uncertain, assume the developer knows something you don't

**Severity tiers** (used by all agents and in the final report):

• **🔴 CRITICAL** — Breaks functionality, exposes data, crashes systems, violates requirements
• **🟠 IMPORTANT** — Missing error handling, unhandled edge cases, potential bugs
• **🟡 DEBT** — Code duplication, convention violations, refactoring needed within 6 months
• **🔵 SUGGESTED** — Measurable improvements only. If you can't measure the improvement, don't suggest it.
• **⚪ QUESTION** — Items requiring human judgment about requirements or intent

**Per-agent quotas** (defined in `_shared.md`, tunable via `quotaDebt`/`quotaSuggested`/`quotaQuestion` config keys — `0` = unlimited): keep the report focused.

---

Phase 0.0: Preflight + Discovery — One Call

**Goal**: probe tools, toolchain, test patterns, and the rules cache in a SINGLE script call, so Phase 0 costs one round trip regardless of cache state.

Execute the bundled script.

bash scripts/discover.sh

It composes `preflight.sh` (tool availability), `detect-toolchain.sh` (steps 0.3 + 0.4), `test-pattern-probe.sh` (step 0.6), probes `.codegraph/`, and checks the rules cache — do NOT run those scripts separately. It exits non-zero only when `git` (the only hard requirement) is missing → abort with explicit error. Parse its single JSON output into the Project Profile:

| Field | Goes to | Meaning | |-------|---------|---------| | `available` | `toolchain.available` | per-binary availability map — see table below | | `toolchain` | `toolchain.ecosystem`/`framework`/`commands` | discovered gate commands; empty string = "not found — gate self-skips" | | `testPattern` | `toolchain.testPattern` | test location/suffix/framework — feeds the Spec Existence Check | | `codegraphIndex` | — | gates Step 0.7: `false` → skip the ToolSearch probe entirely | | `cacheKey` / `cache` / `cachedProfile` | Step 0.2 | rules-cache verdict (`HIT`/`MISS(reason)`) and the cached rules when HIT |

| Tool | Required? | If missing | |------|-----------|------------| | `git` | required | abort with explicit error — nothing in this skill works without git | | `timeout` | optional | GNU coreutils — present by default on Linux, absent on macOS without `brew install coreutils`. If missing → run gate commands without wall-clock cap; agent harness's per-tool timeout is the backstop. Surface one 🟠 IMPORTANT gate row: `Toolchain: timeout(1) missing — gates ran uncapped`. | | `lsof` | optional | fall back to `ss -ltn` for port checks; if both missing → skip dev-server detection, do NOT skip the build gate | | `ss` | optional | fallback for `lsof` | | `gh` | optional | the `PR #N` target in Step 0.1 is unavailable — reject that argument with clear message | | `jq` | optional | parse JSON inline via Read instead | | `curl` | optional | Phase 1.5 runtime probe is skipped | | `rsync` | optional | only the manual installer (`make install`) uses it — the review flow never requires it | | `python3` | optional | `dedupe.py` / `state-sweep.py` / `export-findings.py` / `gate-verdict.py` need it. If missing → dedupe + state sweep degrade to LLM-side grouping, the Export action is unavailable, and gate mode must fail with an explicit message (its verdict JSON comes from `